Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wasm.Build.Tests should not use local targeting runtime pack #53410

Merged
merged 1 commit into from
May 28, 2021
Merged

Wasm.Build.Tests should not use local targeting runtime pack #53410

merged 1 commit into from
May 28, 2021

Conversation

adamsitnik
Copy link
Member

@adamsitnik adamsitnik commented May 28, 2021 •
edited
Loading

fixes #53405

For more context please refer to #53290

@adamsitnik adamsitnik added this to the 6.0.0 milestone May 28, 2021
@ghost
Copy link

ghost commented May 28, 2021

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Hopefully fixes #53405

Author: adamsitnik
Assignees: -
Labels:

area-Infrastructure-coreclr
Milestone: 6.0.0

@ghost
Copy link

ghost commented May 28, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Hopefully fixes #53405

Author: adamsitnik
Assignees: -
Labels:

area-Infrastructure-mono
Milestone: 6.0.0

@adamsitnik adamsitnik requested a review from akoeplinger May 28, 2021 07:13
krwq
krwq approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsitnik adamsitnik merged commit f54a4cd into dotnet:main May 28, 2021
@adamsitnik adamsitnik deleted the fixWasmBuild branch May 28, 2021 08:08
@adamsitnik adamsitnik mentioned this pull request May 28, 2021
Closed
@radical radical mentioned this pull request May 29, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krwq krwq krwq approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

Assignees
No one assigned
Labels
area-Infrastructure-mono
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

[wasm] Wasm.Build.Tests failing
3 participants
@adamsitnik @krwq @hoyosjs